Project

General

Profile

Feature #1035

Get rid of redundant parameters of iaField::getAllFields method

Added by Batyr Mackenov almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Immediate
Assignee:
Batyr Mackenov
Category:
Core
Target version:
3.1.0
Start date:
October 17, 2013
Due date:
% Done:

100%

Estimated time:

Description

All of the packages use this method with the following first parameters:

iaField::getAllFields(true, null, ...);

Will be good to remove the first two of them.

History

#1

Updated by Vasily Bezruchkin almost 6 years ago

  • Assignee set to Batyr Mackenov
  • Priority changed from Normal to Immediate
#2

Updated by Vasily Bezruchkin almost 6 years ago

Use the bridge for released packages cross compatibility:
1. Create a new method with correct params, getFieldsList or anything like that
2. Keep this getAllFields as is but call the new method inside
3. Use the new method in the upcoming packages: Autos, Real Estate, Coupons, Yellow Pages.

#3

Updated by Batyr Mackenov almost 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Method renamed to getByItemName, unused parameters removed.
In order to save a compatibility, kept the old-named method that internally refers to the new one.
commit:3ba3bc9

Also available in: Atom PDF