Project

General

Profile

Bug #426

Duplication of phrases when installing extras

Added by Anonymous almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
-
Category:
Core
Target version:
Start date:
November 12, 2012
Due date:
% Done:

0%

Estimated time:

Description

If xml file has a record like

<phrase category="frontend" key="slogan">...

and this phrase already exists in the database, the script will add the phrase anyway.
So, it will have 2 identical phrases.

If duplicate phrase is met it should replace existed one.

History

#1

Updated by Anonymous almost 7 years ago

  • Assignee changed from Batyr Mackenov to Anonymous
#2

Updated by Vasily Bezruchkin almost 7 years ago

  • Priority changed from Normal to Urgent
#3

Updated by Batyr Mackenov almost 7 years ago

  • Status changed from New to Closed

The way of script currently handles phrases to be added is right.
There is a unique index that simply does not allow the duplicate phrase to be added to DB.
It is ok that the phrase has been added since it specifies a plugin the phrase belongs to. Because the existing slogan phrase has the extras field equal to '' (empty string) and the newly added phrase contains the plugin name in this field, it is right that the phrase has been added. This behavior allows to have distinct translations for different plugins (packages) in case of same phrase keys.

Also available in: Atom PDF